DM-33488: Add pruneDataset method to QuntumBackedButler (DM-33488 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 243 243
Lines 31519 31519
Branches 5894 5894
=======================================
Hits 26617 26617
Misses 3737 3737
Partials 1165 1165 Continue to review full report at Codecov.
|
TallJimbo
approved these changes
Jun 15, 2022
| for ref in refs: | ||
| # We only care about removing them from actual output refs, | ||
| try: | ||
| self._actual_output_refs.remove(ref) |
There was a problem hiding this comment.
Could just use discard instead of remove, without the try/except.
There are few changes to the `pruneDatasets` method: - `run` parameter has been removed completely, it was not used in the standard Butler implementation. - Handling of the execution butler-specific logic is now performed in `Butler.pruneDataset` method, clients are not supposed to know the exact type of butler (and can use LimitedButler where possible). - `QuantumBackedButler.pruneDataset` does not support removal of datasets from tagged collections (which do not exist in QBB).
andy-slac
force-pushed
the
tickets/DM-33488
branch
from
bbbef08
to
6424543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are few changes to the
pruneDatasetsmethod:runparameter has been removed completely, it was not used in thestandard Butler implementation.
Butler.pruneDatasetmethod, clients are not supposed to know theexact type of butler (and can use LimitedButler where possible).
QuantumBackedButler.pruneDatasetdoes not support removal of datasetsfrom tagged collections (which do not exist in QBB).
Checklist
doc/changes