Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35191: Add test matrix for python versions #699

Merged
merged 1 commit into from Jun 13, 2022
Merged

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mwittgen mwittgen changed the title Add test matrix for python versions DM-35047: Add test matrix for python versions Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #699 (4685f18) into main (a18d149) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   84.41%   84.44%   +0.02%     
==========================================
  Files         243      243              
  Lines       31516    31516              
  Branches     5894     5894              
==========================================
+ Hits        26605    26614       +9     
+ Misses       3741     3737       -4     
+ Partials     1170     1165       -5     
Impacted Files Coverage Δ
...ython/lsst/daf/butler/registry/queries/_results.py 84.75% <0.00%> (ø)
python/lsst/daf/butler/datastores/fileDatastore.py 81.02% <0.00%> (+0.11%) ⬆️
python/lsst/daf/butler/_butler.py 79.93% <0.00%> (+0.15%) ⬆️
python/lsst/daf/butler/registry/tests/_registry.py 99.22% <0.00%> (+0.15%) ⬆️
python/lsst/daf/butler/core/config.py 92.29% <0.00%> (+0.20%) ⬆️
python/lsst/daf/butler/registry/tests/_database.py 94.97% <0.00%> (+0.41%) ⬆️
...ython/lsst/daf/butler/registry/dimensions/table.py 85.89% <0.00%> (+0.42%) ⬆️
tests/test_timespan.py 93.19% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18d149...4685f18. Read the comment docs.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I see that it changed the name of the build_and_test action to include the python version number so it looks like I need to tweak the branch protections before you can merge this. It would be nice if the protection could use a wildcard or something.

@mwittgen
Copy link
Contributor Author

This looks good to me. I see that it changed the name of the build_and_test action to include the python version number so it looks like I need to tweak the branch protections before you can merge this. It would be nice if the protection could use a wildcard or something.

Correct. I didn't want to mess with the protected branches before this gets merged.

@mwittgen mwittgen changed the title DM-35047: Add test matrix for python versions DM-35191: Add test matrix for python versions Jun 13, 2022
@mwittgen mwittgen merged commit 4094fce into main Jun 13, 2022
@mwittgen mwittgen deleted the tickets/DM-35191 branch June 13, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants