Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35469: Make the storage class redefinition error message clearer #706

Merged
merged 3 commits into from Jul 6, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jul 6, 2022

Now uses repr() so that the differences are reported (str reported
just the name, which was already known to match)

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Now uses repr() so that the differences are reported (str reported
just the name, which was already known to match)
@timj timj marked this pull request as ready for review July 6, 2022 16:37
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #706 (3b87561) into main (aeba0b4) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files         243      243           
  Lines       31814    31825   +11     
  Branches     5963     5966    +3     
=======================================
+ Hits        26896    26906   +10     
  Misses       3747     3747           
- Partials     1171     1172    +1     
Impacted Files Coverage Δ
python/lsst/daf/butler/core/config.py 92.11% <50.00%> (-0.18%) ⬇️
python/lsst/daf/butler/core/storageClass.py 93.57% <90.90%> (+0.09%) ⬆️
tests/test_storageClass.py 98.91% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeba0b4...3b87561. Read the comment docs.

@timj
Copy link
Member Author

timj commented Jul 6, 2022

@TallJimbo sorry, can you please take a second look at this. I cracked and decided to add the file name (where available) to the error message so we know which file is causing the problem (although I'm not yet retaining a list of all previous config files that have been read to provide further information).

@timj timj requested a review from TallJimbo July 6, 2022 20:04
@timj timj merged commit df4b34c into main Jul 6, 2022
@timj timj deleted the tickets/DM-35469 branch July 6, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants