Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35272: Add optional dependencies for postgres #712

Merged
merged 2 commits into from Jul 19, 2022
Merged

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mwittgen mwittgen requested a review from timj July 12, 2022 23:42
@mwittgen mwittgen changed the title Add optional dependencies for postgres DM-35272: Add optional dependencies for postgres Jul 12, 2022
pyproject.toml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #712 (76e3083) into main (1dd4775) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files         243      243           
  Lines       31916    31916           
  Branches     5990     5990           
=======================================
  Hits        27002    27002           
  Misses       3744     3744           
  Partials     1170     1170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd4775...76e3083. Read the comment docs.

@timj timj requested a review from r-owen July 15, 2022 18:12
Copy link

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new extra [postgres] is not working yet.

@mwittgen mwittgen merged commit ca6001c into main Jul 19, 2022
@mwittgen mwittgen deleted the tickets/DM-35272 branch July 19, 2022 18:40
Copy link

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the optional postgres installation option. It seems to work well.

I can't comment on the change to workflows/build.yaml as I don't understand the details, but am happy to assume it's correct.

Copy link

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Trying again. the last time this showed up as a comment instead of as a review).

Approved. See previous comment.

@mwittgen
Copy link
Contributor Author

Thanks. It's uploaded to PyPi now. https://pypi.org/project/lsst-daf-butler/

@timj
Copy link
Member

timj commented Jul 19, 2022

I wasn't expecting you to force a tag build on this one. Waiting until the weekly tomorrow night would have been fine.

@mwittgen
Copy link
Contributor Author

mwittgen commented Jul 19, 2022

Sorry, I know creating a tag for this purpose is not ideal.
I try to minimize my mistakes in the future. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants