New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35272: Add optional dependencies for postgres #712
Conversation
Codecov Report
@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 243 243
Lines 31916 31916
Branches 5990 5990
=======================================
Hits 27002 27002
Misses 3744 3744
Partials 1170 1170 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new extra [postgres]
is not working yet.
2c6af29
to
76e3083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the optional postgres installation option. It seems to work well.
I can't comment on the change to workflows/build.yaml as I don't understand the details, but am happy to assume it's correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Trying again. the last time this showed up as a comment instead of as a review).
Approved. See previous comment.
Thanks. It's uploaded to PyPi now. https://pypi.org/project/lsst-daf-butler/ |
I wasn't expecting you to force a tag build on this one. Waiting until the weekly tomorrow night would have been fine. |
Sorry, I know creating a tag for this purpose is not ideal. |
Checklist
doc/changes