Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35803: Add DataFrame delegate to enable InMemoryDatasets of DataFrames. #720

Merged
merged 3 commits into from Aug 30, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Aug 3, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@erykoff erykoff force-pushed the tickets/DM-35803 branch 2 times, most recently from e16bacd to 99a8a4b Compare August 3, 2022 01:12
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #720 (b0940af) into main (bf1ffe9) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b0940af differs from pull request most recent head 3a7b71e. Consider uploading reports for the commit 3a7b71e to get more accurate results

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   84.63%   84.62%   -0.01%     
==========================================
  Files         243      243              
  Lines       32013    31990      -23     
  Branches     6004     6003       -1     
==========================================
- Hits        27093    27071      -22     
+ Misses       3748     3747       -1     
  Partials     1172     1172              
Impacted Files Coverage Δ
...n/lsst/daf/butler/registry/interfaces/_datasets.py 73.68% <0.00%> (-2.21%) ⬇️
python/lsst/daf/butler/registry/_registry.py 72.67% <0.00%> (-0.30%) ⬇️
python/lsst/daf/butler/registries/sql.py 81.08% <0.00%> (-0.04%) ⬇️
python/lsst/daf/butler/registry/tests/_registry.py 99.22% <0.00%> (-0.01%) ⬇️
python/lsst/daf/butler/__init__.py 100.00% <0.00%> (ø)
python/lsst/daf/butler/registries/remote.py 0.00% <0.00%> (ø)
.../butler/registry/datasets/byDimensions/_storage.py 84.39% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this. Lots of minor comments to consider but no big issues.

python/lsst/daf/butler/delegates/__init__.py Outdated Show resolved Hide resolved
doc/changes/DM-35803.feature.rst Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/dataframe.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/dataframe.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/dataframe.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/dataframe.py Outdated Show resolved Hide resolved
tests/test_parquet.py Outdated Show resolved Hide resolved
tests/test_parquet.py Show resolved Hide resolved
tests/test_parquet.py Outdated Show resolved Hide resolved
tests/test_parquet.py Outdated Show resolved Hide resolved
@erykoff erykoff force-pushed the tickets/DM-35803 branch 5 times, most recently from 5df2327 to 92dd19e Compare August 4, 2022 00:01
@erykoff erykoff force-pushed the tickets/DM-35803 branch 3 times, most recently from a46cc4e to 9b45ed1 Compare August 29, 2022 21:47
@erykoff erykoff merged commit 3ee7dd6 into main Aug 30, 2022
@erykoff erykoff deleted the tickets/DM-35803 branch August 30, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants