DM-35917: Update split_commas to understand [] list syntax #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 84.65% 84.66% +0.01%
==========================================
Files 243 243
Lines 32020 32056 +36
Branches 6007 6020 +13
==========================================
+ Hits 27107 27141 +34
- Misses 3743 3744 +1
- Partials 1170 1171 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andy-slac
approved these changes
Aug 24, 2022
"a[1,2]" will no longer be split.
It has been decided that it's too dangerous since it is plausible that someone might want to have a string config item with a comma in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"a[1,2]" will no longer be split.
Checklist
doc/changes