DM-15402: Fix race conditions in tests and enhance Config test coverage #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Aug 11, 2018
There was a problem hiding this comment.
Looks great! Glad you didn't take my word in my misdiagnosis of the last race condition I saw.
Only comment I have is that it might be good to put the Datastore test helper in a tests subpackage of the main lsst.daf.butler package, so it could be used to test hypothetical Datastores defined in other packages.
There was a copy and paste error in datastoreFits and this code sharing fixes that so we do not reuse the same directory.
* Now have 95% test coverage * Remove code that doesn't seem to be doing anything. * Remove <, > operators. * Add tests for names() and asArray()
|
I'll merge this now and worry about a tests module later. My main reason is that creating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition and whilst doing that we needed to update test coverage of config (there was concern that the tests did not show a failure when they should have).