DM-36326: Simplify materialized skypix overlaps. #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Oct 5, 2022
| @@ -125,28 +120,12 @@ def initialize( | |||
| table = context.addTable(element.name, spec) | |||
| else: | |||
| table = db.ensureTableExists(element.name, spec) | |||
| skyPixOverlap: _SkyPixOverlapStorage | None | |||
| skypix_overlap_tables: _SkyPixOverlapTables | None | |||
There was a problem hiding this comment.
Does this declaration do anything useful?
There was a problem hiding this comment.
Good catch; it does not.
| return result | ||
|
|
||
| def connect(self, overlaps: DatabaseDimensionOverlapStorage) -> None: | ||
| # Docstring inherited from DatabaseDimensionRecordStorage. | ||
| self._otherOverlaps.append(overlaps) | ||
|
|
||
| def _on_governor_insert(self, record: DimensionRecord) -> None: | ||
| """A `GovernorDimensionRecordStorage.registerInsertionListener callback |
There was a problem hiding this comment.
Closing backtick is missing.
| Record storage backend for this element's governor dimension. | ||
| Parameters | ||
| ---------- | ||
| records : `Sequence` [ `DimensionElement` ] |
There was a problem hiding this comment.
DimensionElement -> DimensionRecord?
| to require users to explicitly materialize all relationships they will | ||
| want to use in queries. | ||
| This class (and the related methods in TableDimensionRecordStorage) can in | ||
| principle manage overlaps between with any skypix dimension, but at present |
We were maintaining a lot of unused, probably too-clever code for dealing with spatial overlaps between regular database dimension elements and arbitrary skypix dimensions, while only overlaps with the common skypix dimension are actually supported everywhere else. This commit drops that extra complexity, and with it an undesirable dependency on GovernorDimensionRecordStorage.values (which I'd like to remove) and some unnecessary table locking.
TallJimbo
force-pushed
the
tickets/DM-36326
branch
from
e0e24c4
to
d976a5a
Compare
Codecov ReportBase: 84.74% // Head: 84.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 84.74% 84.79% +0.04%
==========================================
Files 254 254
Lines 32960 32911 -49
Branches 5639 5618 -21
==========================================
- Hits 27933 27907 -26
+ Misses 3802 3783 -19
+ Partials 1225 1221 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were maintaining a lot of unused, probably too-clever code for dealing with spatial overlaps between regular database dimension elements and arbitrary skypix dimensions, while only overlaps with the common skypix dimension are actually supported everywhere else.
This commit drops that extra complexity, and with it an undesirable dependency on GovernorDimensionRecordStorage.values (which I'd like to remove) and some unnecessary table locking.
Checklist
doc/changes