Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34874: Refactor parquet formatter to use Arrow Tables natively, and add converters. #741

Merged
merged 5 commits into from Oct 27, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 7, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 84.94% // Head: 85.29% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (5616ef3) compared to base (e155f61).
Patch coverage: 97.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   84.94%   85.29%   +0.35%     
==========================================
  Files         257      260       +3     
  Lines       33431    34338     +907     
  Branches     5692     5800     +108     
==========================================
+ Hits        28398    29289     +891     
- Misses       3804     3814      +10     
- Partials     1229     1235       +6     
Impacted Files Coverage Δ
python/lsst/daf/butler/formatters/parquet.py 94.04% <93.87%> (+2.61%) ⬆️
python/lsst/daf/butler/delegates/arrowtable.py 94.28% <94.28%> (ø)
tests/test_parquet.py 98.52% <98.97%> (+4.03%) ⬆️
python/lsst/daf/butler/delegates/arrowastropy.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/delegates/arrownumpy.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/delegates/dataframe.py 90.47% <100.00%> (+7.14%) ⬆️
python/lsst/daf/butler/core/logging.py 96.19% <0.00%> (-0.48%) ⬇️
python/lsst/daf/butler/core/storageClass.py 94.49% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cleanups noted and I worry about code duplication.

Thanks for the comprehensive tests with excellent code coverage.

python/lsst/daf/butler/delegates/arrowastropy.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/arrowastropy.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/delegates/arrownumpy.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/parquet.py Show resolved Hide resolved
@erykoff erykoff force-pushed the tickets/DM-34874 branch 2 times, most recently from 5115525 to 6098a4f Compare October 27, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants