Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36410: Support "move" ingest into chained datastore #742

Merged
merged 2 commits into from Oct 11, 2022
Merged

Conversation

timj
Copy link
Member

@timj timj commented Oct 8, 2022

Treat it as a copy and then clean up.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Treat it as a copy and then clean up.
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 84.80% // Head: 84.81% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3fadd14) compared to base (07bf668).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   84.80%   84.81%           
=======================================
  Files         254      254           
  Lines       32967    32980   +13     
  Branches     5630     5636    +6     
=======================================
+ Hits        27959    27972   +13     
  Misses       3785     3785           
  Partials     1223     1223           
Impacted Files Coverage Δ
...hon/lsst/daf/butler/datastores/chainedDatastore.py 87.53% <100.00%> (+0.39%) ⬆️
tests/test_butler.py 97.68% <100.00%> (+<0.01%) ⬆️
tests/test_datastore.py 99.28% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj marked this pull request as ready for review October 11, 2022 15:19
@timj timj requested a review from andy-slac October 11, 2022 15:44
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 8aa4553 into main Oct 11, 2022
@timj timj deleted the tickets/DM-36410 branch October 11, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants