DM-36517: Add support for ChainedDatastore.export() #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-36517
branch
from
fa9b225
to
1388ee2
Compare
Codecov ReportBase: 84.88% // Head: 84.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 84.88% 84.94% +0.06%
==========================================
Files 257 257
Lines 33342 33431 +89
Branches 5667 5692 +25
==========================================
+ Hits 28302 28398 +96
+ Misses 3807 3804 -3
+ Partials 1233 1229 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timj
force-pushed
the
tickets/DM-36517
branch
from
8564073
to
373ec5c
Compare
andy-slac
approved these changes
Oct 12, 2022
timj
force-pushed
the
tickets/DM-36517
branch
2 times, most recently
from
f50644a
to
cd3f212
Compare
This method can run the knows() method in bulk.
Adjust the test inheritance such that the export tests are now run for the ChainedDatastore
This required we change the exception type in some failure modes to match that raise by butler.export.
Also include test with a missing dataset.
This requires that auto be converted to None if no directory is given. FileDatastore and ChainedDatastore already had "auto" as a default.
We had not noticed it was wrong until the pyyaml types package added an annotation for loader.construct_mapping()
timj
force-pushed
the
tickets/DM-36517
branch
from
369dbd9
to
fdb33ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes