New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-36489: Add pgSphere support to obscore manager #744
Conversation
I realized that schema migration will be more complicated with separate subclasses which are controlled by obscore configuration. Merging them into a single class, as I originally tried to do. It is slightly more messier, but will work better with schema migration tools.
0b21a27
to
f3daa2d
Compare
Codecov ReportBase: 84.81% // Head: 84.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 84.81% 84.82% +0.01%
==========================================
Files 254 257 +3
Lines 32980 33201 +221
Branches 5636 5662 +26
==========================================
+ Hits 27972 28164 +192
- Misses 3785 3805 +20
- Partials 1223 1232 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
48f1574
to
f124c44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just a few minor comments.
But codecov seems pretty convinced that your tests aren't actually exercising any of the pgSphere stuff, despite the tests' clear intent to do that. I suspect that means something's gone wrong in either the installation or the test-skipping logic.
I'm not sure that this is true. I checked |
f124c44
to
0861648
Compare
Obscore manager adds generic plugin mechanisms to support spatial columns and indices. A specific implementation using pgSphere extension adds two columns and corresponding indices that contain pgSphere polygon and position (center of bounding circle) to obscore table.
0861648
to
57695bf
Compare
Obscore manager adds generic plugin mechanisms to support spatial columns
and indices. A specific implementation using pgSphere extension adds
two columns and corresponding indices that contain pgSphere polygon and
position (center of bounding circle) to obscore table.
Checklist
doc/changes