Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36775: Refactor string length checking on dataframe->arrow conversion. #747

Merged
merged 1 commit into from Oct 28, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 28, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 85.29% // Head: 85.28% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f3c3f11) compared to base (ee902a2).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   85.29%   85.28%   -0.01%     
==========================================
  Files         260      260              
  Lines       34338    34336       -2     
  Branches     5800     5800              
==========================================
- Hits        29288    29284       -4     
- Misses       3815     3816       +1     
- Partials     1235     1236       +1     
Impacted Files Coverage Δ
python/lsst/daf/butler/formatters/parquet.py 93.37% <80.00%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@erykoff erykoff merged commit 422d82b into main Oct 28, 2022
@erykoff erykoff deleted the tickets/DM-36775 branch October 28, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants