DM-36795: Fix pandas dataframe to arrow crash with partially nulled string columns. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.28% // Head: 85.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
=======================================
Coverage 85.28% 85.29%
=======================================
Files 260 260
Lines 34336 34348 +12
Branches 5800 5800
=======================================
+ Hits 29284 29296 +12
Misses 3816 3816
Partials 1236 1236
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ktlim
reviewed
Oct 29, 2022
tests/test_parquet.py
Outdated
| self.assertTrue(df1.equals(df2)) | ||
|
|
||
| def testSingleIndexDataFrameAllEmptyStrings(self): | ||
| """Test persisting a single index dataframe with an emptry string |
There was a problem hiding this comment.
Suggested change
| """Test persisting a single index dataframe with an emptry string | |
| """Test persisting a single index dataframe with an empty string |
ktlim
approved these changes
Oct 29, 2022
erykoff
force-pushed
the
tickets/DM-36795
branch
from
a8e0cc8
to
1a8c4f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes