DM-36918: Protect against the new cache file being deleted before it can be registered #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istered This usually means that the cache size is too small for the number of processes writing to the cache.
czwa
approved these changes
Nov 8, 2022
x : T = None should be written as x : T | None = None
mypy now seems to understand hasattr checks so does not complain if you check for an attribute and then use that attribute.
Codecov ReportBase: 85.29% // Head: 85.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 85.29% 85.30%
=======================================
Files 260 260
Lines 34348 34375 +27
Branches 5800 5803 +3
=======================================
+ Hits 29298 29323 +25
Misses 3815 3815
- Partials 1235 1237 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mypy worked out that the no-arg version was never going to work because the parent implementation was abstract. We could not use MutableSet directly so implemented it in a similar way. Tests were added.
Found by mypy 0.990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This usually means that the cache size is too small for the number of processes writing to the cache.
Checklist
doc/changes