Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36597: Add LATISS filter transmission data #752

Merged
merged 1 commit into from Nov 29, 2022
Merged

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Nov 8, 2022

Add converters for TransmissionCurve.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 85.33% // Head: 85.30% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2406860) compared to base (c9c437b).
Patch has no changes to coverable lines.

❗ Current head 2406860 differs from pull request most recent head c81183e. Consider uploading reports for the commit c81183e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   85.33%   85.30%   -0.03%     
==========================================
  Files         260      260              
  Lines       34535    34375     -160     
  Branches     5813     5803      -10     
==========================================
- Hits        29469    29323     -146     
+ Misses       3823     3815       -8     
+ Partials     1243     1237       -6     
Impacted Files Coverage Δ
python/lsst/daf/butler/tests/_testRepo.py 77.30% <0.00%> (-13.86%) ⬇️
python/lsst/daf/butler/script/butlerImport.py 66.66% <0.00%> (-11.12%) ⬇️
python/lsst/daf/butler/script/_associate.py 50.00% <0.00%> (-10.00%) ⬇️
...on/lsst/daf/butler/script/queryDimensionRecords.py 64.00% <0.00%> (-5.24%) ⬇️
python/lsst/daf/butler/script/exportCalibs.py 14.54% <0.00%> (-4.10%) ⬇️
...thon/lsst/daf/butler/script/certifyCalibrations.py 31.25% <0.00%> (-4.05%) ⬇️
python/lsst/daf/butler/tests/utils.py 94.04% <0.00%> (-3.63%) ⬇️
python/lsst/daf/butler/script/retrieveArtifacts.py 85.71% <0.00%> (-1.79%) ⬇️
python/lsst/daf/butler/script/configValidate.py 83.33% <0.00%> (-1.29%) ⬇️
...ython/lsst/daf/butler/registry/obscore/pgsphere.py 87.32% <0.00%> (-0.68%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czwa czwa requested a review from timj November 11, 2022 22:08
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've already reviewed this.

@czwa
Copy link
Contributor Author

czwa commented Nov 11, 2022

Sorry, I hadn't clicked out of the "assign reviewer" box in this tab until today, and it looks like that sent a second message.

@czwa czwa merged commit 6986e7d into main Nov 29, 2022
@czwa czwa deleted the tickets/DM-36597 branch November 29, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants