DM-36984: Fix astropy table test code #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.30% // Head: 85.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 260 260
Lines 34382 34385 +3
Branches 5806 5806
=======================================
+ Hits 29330 29333 +3
Misses 3815 3815
Partials 1237 1237
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erykoff
approved these changes
Nov 14, 2022
Rather than using the textual diff (which elides columns depending on terminal width unless overridden) ask astropy to format all the lines of the table into tuples and then compare the tuples.
We did not notice they were missing because the table comparison code was stringifying the tables and inside pytest this meant that a few columns were elided because of the default pytest terminal width setting.
timj
force-pushed
the
tickets/DM-36984
branch
from
5d81ee1
to
bea5bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes