New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-37036: Fix type annotations in lsst.daf.butler.tests #756
Conversation
Codecov ReportBase: 85.29% // Head: 85.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 85.29% 85.33% +0.03%
==========================================
Files 260 260
Lines 34468 34535 +67
Branches 5810 5813 +3
==========================================
+ Hits 29401 29469 +68
+ Misses 3824 3823 -1
Partials 1243 1243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9169221
to
3c73d91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few minor comments.
IO, | ||
Any, | ||
Callable, | ||
ClassVar, | ||
Dict, | ||
Generator, | ||
Iterable, | ||
Iterator, | ||
List, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these should come from collections.abc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although I wasn't fixing up old syntax in core files (black reformatted it because I added overload).
3c73d91
to
4ae390e
Compare
4ae390e
to
148a536
Compare
Checklist
doc/changes