Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37036: Fix type annotations in lsst.daf.butler.tests #756

Merged
merged 2 commits into from Nov 18, 2022
Merged

Conversation

timj
Copy link
Member

@timj timj commented Nov 17, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 85.29% // Head: 85.33% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (148a536) compared to base (b839107).
Patch coverage: 84.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   85.29%   85.33%   +0.03%     
==========================================
  Files         260      260              
  Lines       34468    34535      +67     
  Branches     5810     5813       +3     
==========================================
+ Hits        29401    29469      +68     
+ Misses       3824     3823       -1     
  Partials     1243     1243              
Impacted Files Coverage Δ
python/lsst/daf/butler/core/storageClass.py 93.93% <ø> (ø)
python/lsst/daf/butler/tests/cliCmdTestBase.py 73.84% <65.21%> (-6.52%) ⬇️
python/lsst/daf/butler/core/logging.py 95.83% <71.42%> (-0.84%) ⬇️
python/lsst/daf/butler/tests/cliLogTestBase.py 85.90% <74.19%> (-4.54%) ⬇️
python/lsst/daf/butler/tests/_datasetsHelper.py 84.05% <85.71%> (+0.12%) ⬆️
...ython/lsst/daf/butler/tests/_examplePythonTypes.py 88.11% <85.71%> (-2.00%) ⬇️
python/lsst/daf/butler/tests/utils.py 97.67% <85.71%> (+3.42%) ⬆️
python/lsst/daf/butler/tests/_testRepo.py 91.15% <92.30%> (+13.85%) ⬆️
python/lsst/daf/butler/tests/_dummyRegistry.py 85.55% <95.23%> (+0.32%) ⬆️
python/lsst/daf/butler/tests/deferredFormatter.py 77.77% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor comments.

Comment on lines +30 to +38
IO,
Any,
Callable,
ClassVar,
Dict,
Generator,
Iterable,
Iterator,
List,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these should come from collections.abc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although I wasn't fixing up old syntax in core files (black reformatted it because I added overload).

python/lsst/daf/butler/tests/_datasetsHelper.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/tests/_examplePythonTypes.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/tests/_examplePythonTypes.py Outdated Show resolved Hide resolved
@timj timj merged commit c9c437b into main Nov 18, 2022
@timj timj deleted the tickets/DM-37036 branch November 18, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants