DM-37173: Rewrite getURIs to use getManyURIs #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.32% // Head: 85.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 85.32% 85.32% -0.01%
==========================================
Files 260 260
Lines 34539 34560 +21
Branches 5813 5819 +6
==========================================
+ Hits 29472 29488 +16
- Misses 3823 3826 +3
- Partials 1244 1246 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This allows Datastore to assume that a DatasetRef is always hashable.
The DummyRegistry used for datastore tests needs to be able to rollback inserts if the transaction fails.
Previously only datastore records were queried.
This lets us reuse the logic in the other method and also ensures that the logic is the same in that we only look on disk in "trust" mode when there is no corresponding datastore record.
timj
force-pushed
the
tickets/DM-37173
branch
from
fb1efa7
to
2b4beec
Compare
TallJimbo
approved these changes
Dec 6, 2022
State that the transaction object is only needed if a database is not going to roll back automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes