DM-33497: Improve support for quantum-backed butler #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.91% // Head: 84.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 84.91% 84.89% -0.03%
==========================================
Files 267 267
Lines 35021 35052 +31
Branches 5983 5990 +7
==========================================
+ Hits 29739 29758 +19
- Misses 4000 4009 +9
- Partials 1282 1285 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TallJimbo
changed the title
TallJimbo
approved these changes
Jan 3, 2023
andy-slac
force-pushed
the
tickets/DM-33497
branch
6 times, most recently
from
a6d3865
to
a6b9e10
Compare
The source butler in transfer_from is now a `LimitedButler` to support transfer from `QuantumBackedBUtler`. If input data IDs are not expanded we need access to registry, so it has to resort to dynamic type checking using `getattr`.
Move that option definition to `cli.opt` to enable its reuse by a new CLI command in `pipe_base` package.
andy-slac
force-pushed
the
tickets/DM-33497
branch
from
a6b9e10
to
a2af9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small changes needed for implementation of new pipetask command that use quantum-backed-butler.
Checklist
doc/changes