Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37855: Fix query order_by failure due to inconsistent handling of pkeys. #778

Merged
merged 2 commits into from Feb 6, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Feb 4, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@TallJimbo TallJimbo changed the title DM-37811: Fix query order_by failure due to inconsistent handling of pkeys. DM-3785: Fix query order_by failure due to inconsistent handling of pkeys. Feb 4, 2023
@TallJimbo TallJimbo changed the title DM-3785: Fix query order_by failure due to inconsistent handling of pkeys. DM-37855: Fix query order_by failure due to inconsistent handling of pkeys. Feb 4, 2023
@TallJimbo TallJimbo force-pushed the tickets/DM-37855 branch 2 times, most recently from fea1584 to 9c205fc Compare February 4, 2023 03:52
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 85.60% // Head: 85.56% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (86c054c) compared to base (6140c9f).
Patch coverage: 95.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   85.60%   85.56%   -0.04%     
==========================================
  Files         269      269              
  Lines       35359    35279      -80     
  Branches     6025     6026       +1     
==========================================
- Hits        30268    30188      -80     
- Misses       3772     3775       +3     
+ Partials     1319     1316       -3     
Impacted Files Coverage Δ
tests/test_butler.py 98.18% <ø> (+0.50%) ⬆️
.../butler/registry/queries/expressions/categorize.py 80.00% <93.75%> (+0.45%) ⬆️
python/lsst/daf/butler/registry/tests/_registry.py 98.47% <100.00%> (+<0.01%) ⬆️
python/lsst/daf/butler/formatters/pickle.py 67.85% <0.00%> (-3.58%) ⬇️
python/lsst/daf/butler/datastores/fileDatastore.py 80.89% <0.00%> (-0.54%) ⬇️
python/lsst/daf/butler/core/formatter.py 87.25% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

These are now covered by tests in the resources package; from the
butler perspective http and s3 datastores should be identical.
@TallJimbo TallJimbo merged commit 356a7da into main Feb 6, 2023
@TallJimbo TallJimbo deleted the tickets/DM-37855 branch February 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants