Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37873: Fix code to remove obscore manager in makeRepo #779

Merged
merged 2 commits into from Feb 7, 2023

Conversation

timj
Copy link
Member

@timj timj commented Feb 6, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj marked this pull request as ready for review February 6, 2023 23:06
@timj timj requested a review from andy-slac February 6, 2023 23:07
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 85.56% // Head: 85.56% // No change to project coverage 👍

Coverage data is based on head (3ed6faa) compared to base (356a7da).
Patch coverage: 33.33% of modified lines in pull request are covered.

❗ Current head 3ed6faa differs from pull request most recent head a533ab8. Consider uploading reports for the commit a533ab8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         269      269           
  Lines       35279    35279           
  Branches     6026     6026           
=======================================
  Hits        30188    30188           
  Misses       3775     3775           
  Partials     1316     1316           
Impacted Files Coverage Δ
python/lsst/daf/butler/_butler.py 78.61% <0.00%> (ø)
python/lsst/daf/butler/tests/_datasetsHelper.py 84.05% <0.00%> (ø)
python/lsst/daf/butler/core/datasets/ref.py 83.06% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 8ec445a into main Feb 7, 2023
@timj timj deleted the tickets/DM-37873 branch February 7, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants