DM-37939: Skip obscore test when pg_sphere is missing #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-37939
branch
from
eac988c
to
c0095ed
Compare
The fix only changes type of the exception checked when pg_sphere extension is installed. The logic which skips the test is already there.
andy-slac
force-pushed
the
tickets/DM-37939
branch
from
c0095ed
to
4a70600
Compare
Codecov ReportBase: 85.59% // Head: 85.59% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 269 269
Lines 35357 35357
Branches 7428 7428
=======================================
Hits 30264 30264
Misses 3771 3771
Partials 1322 1322
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TallJimbo
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix only changes type of the exception checked when pg_sphere extension is installed. The logic which skips the test is already there.
Checklist
doc/changes