DM-37938: additional spatial constraint query fixes and testing #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-37938
branch
from
5a517e4
to
21ed0d5
Compare
|
The |
This provides a new approach to testing registry queries that won't require as much work setting up appropriate test data and inspecting it to independently determine expected query results, and I'm looking forward to adding more tests here on future tickets; so far this just focuses on the spatial constraint queries that we apparently had particularly poor test coverage previously, leading to lots of breakage on DM-31725. Some of these tests are expected to fail right now, but will be fixed shortly.
There was a bit of a mess here previously - two nearly-identical blocks for deciding which columns would be included in the query, and one of them going unused; I think that's relic of a poorly-resolved rebase conflict somewhere in the long development of DM-31725.
There's currently no high-level way to populate these arguments to our lower-level query classes; the only way one can currently do temporal constraints is to write them out in the 'where' argument, and that doesn't use any of this. I've made this a separate commit because I think we may want to revert it after we've got a public interface (possibly on Butler rather than Registry) that's designed to support all of the things the daf_relation query system could now do. But for now it's just dead weight.
TallJimbo
force-pushed
the
tickets/DM-37938
branch
from
7838239
to
80c95a8
Compare
Codecov ReportBase: 85.49% // Head: 85.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 85.49% 85.51% +0.02%
==========================================
Files 265 266 +1
Lines 35047 35075 +28
Branches 6004 7358 +1354
==========================================
+ Hits 29964 29996 +32
+ Misses 3768 3766 -2
+ Partials 1315 1313 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also lsst/daf_relation#6
Checklist
doc/changes