New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34568: Add tuple parameter support to removeDatasetType #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comments on the draft. Once you've dealt with these you will also need to change the click interface in commands.py so that it can accept multiple values for the dataset type name since it currently says nargs=1
.
cee6d9f
to
44bdd17
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 85.54% 85.56% +0.01%
==========================================
Files 266 266
Lines 35186 35227 +41
Branches 7388 7395 +7
==========================================
+ Hits 30100 30142 +42
Misses 3768 3768
+ Partials 1318 1317 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Note to future self: update release notes before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very minor comments. Try to squash the fixes into the relevant earlier commit.
edf2cf3
to
9b55e00
Compare
9b55e00
to
37a4c0a
Compare
8f289d9
to
d317ff9
Compare
Checklist
doc/changes