Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34568: Add tuple parameter support to removeDatasetType #789

Merged
merged 3 commits into from Mar 4, 2023

Conversation

Fireye04
Copy link
Member

@Fireye04 Fireye04 commented Feb 11, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments on the draft. Once you've dealt with these you will also need to change the click interface in commands.py so that it can accept multiple values for the dataset type name since it currently says nargs=1.

tests/test_butler.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registries/sql.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registries/sql.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registries/sql.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registries/sql.py Outdated Show resolved Hide resolved
tests/test_butler.py Outdated Show resolved Hide resolved
@Fireye04 Fireye04 requested a review from timj February 17, 2023 20:29
@Fireye04 Fireye04 force-pushed the tickets/DM-34568 branch 2 times, most recently from cee6d9f to 44bdd17 Compare February 17, 2023 20:41
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (2a9a601) 85.54% compared to head (d317ff9) 85.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   85.54%   85.56%   +0.01%     
==========================================
  Files         266      266              
  Lines       35186    35227      +41     
  Branches     7388     7395       +7     
==========================================
+ Hits        30100    30142      +42     
  Misses       3768     3768              
+ Partials     1318     1317       -1     
Impacted Files Coverage Δ
python/lsst/daf/butler/cli/cmd/commands.py 89.65% <100.00%> (ø)
python/lsst/daf/butler/registries/remote.py 69.43% <100.00%> (ø)
python/lsst/daf/butler/registries/sql.py 83.69% <100.00%> (+0.19%) ⬆️
python/lsst/daf/butler/registry/_registry.py 72.82% <100.00%> (ø)
python/lsst/daf/butler/script/removeDatasetType.py 100.00% <100.00%> (ø)
tests/test_butler.py 97.67% <100.00%> (+0.01%) ⬆️
tests/test_cliCmdQueryDatasetTypes.py 97.82% <100.00%> (+1.00%) ⬆️
.../butler/registry/datasets/byDimensions/_manager.py 91.78% <0.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Fireye04
Copy link
Member Author

Note to future self: update release notes before merging

@Fireye04 Fireye04 marked this pull request as ready for review February 18, 2023 00:19
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very minor comments. Try to squash the fixes into the relevant earlier commit.

python/lsst/daf/butler/cli/cmd/commands.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registries/sql.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registry/_registry.py Outdated Show resolved Hide resolved
tests/test_cliCmdQueryDatasetTypes.py Outdated Show resolved Hide resolved
@Fireye04 Fireye04 force-pushed the tickets/DM-34568 branch 2 times, most recently from edf2cf3 to 9b55e00 Compare March 3, 2023 18:51
@Fireye04 Fireye04 merged commit 6dff023 into main Mar 4, 2023
@Fireye04 Fireye04 deleted the tickets/DM-34568 branch March 4, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants