Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33932: Remove the spectraction dataset type #793

Merged
merged 2 commits into from Mar 9, 2023
Merged

Conversation

mfisherlevine
Copy link
Contributor

@mfisherlevine mfisherlevine commented Feb 24, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8116dd0) 85.63% compared to head (fafc0e0) 85.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         266      266           
  Lines       35180    35180           
  Branches     7380     7380           
=======================================
  Hits        30127    30127           
  Misses       3735     3735           
  Partials     1318     1318           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay given the removal notice that no-one should have ever really used the storage class. Removing a storage class makes it impossible to access a dataset.

doc/changes/DM-33932.removal.md Outdated Show resolved Hide resolved
@mfisherlevine mfisherlevine force-pushed the tickets/DM-33932 branch 3 times, most recently from 6ab7caf to 083e9d2 Compare March 8, 2023 21:02
@mfisherlevine mfisherlevine merged commit a415d2f into main Mar 9, 2023
@mfisherlevine mfisherlevine deleted the tickets/DM-33932 branch March 9, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants