DM-13370: Rebrand as lsst.daf.butler #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pschella has approved verbally. |
DinoBektesevic
added a commit
to DinoBektesevic/daf_butler
that referenced
this pull request
Aug 4, 2019
Schemeless URIs handled more smoothly in ButlerURI. Removed s3CheckFileExistsGET and s3CheckFileExistsLIST for a singular s3CheckFileExists function, as botocore is up to date now on coda and on pip so GET/HEAD requests make no performance difference anymore. Live testing shows possibility that HTTP 403 response is returned for HEAD requests when file does not exist and user does not have s3:ListBucket permissions. Added a more informative error message. Changed the s3utils function signatures to look more alike. Changed an instance of os.path to posixpath join in test_butler to be more consistent with what is expected from used URIs. Corrected Config.__initFromS3Yaml to use an URL instead of path and Config.__initFromYaml to use ospath.
DinoBektesevic
added a commit
to DinoBektesevic/daf_butler
that referenced
this pull request
Aug 4, 2019
Schemeless URIs handled more smoothly in ButlerURI. Removed s3CheckFileExistsGET and s3CheckFileExistsLIST for a singular s3CheckFileExists function, as botocore is up to date now on coda and on pip so GET/HEAD requests make no performance difference anymore. Live testing shows possibility that HTTP 403 response is returned for HEAD requests when file does not exist and user does not have s3:ListBucket permissions. Added a more informative error message. Changed the s3utils function signatures to look more alike. Changed an instance of os.path to posixpath join in test_butler to be more consistent with what is expected from used URIs. Corrected Config.__initFromS3Yaml to use an URL instead of path and Config.__initFromYaml to use ospath.
DinoBektesevic
added a commit
to DinoBektesevic/daf_butler
that referenced
this pull request
Aug 6, 2019
Schemeless URIs handled more smoothly in ButlerURI. Removed s3CheckFileExistsGET and s3CheckFileExistsLIST for a singular s3CheckFileExists function, as botocore is up to date now on coda and on pip so GET/HEAD requests make no performance difference anymore. Live testing shows possibility that HTTP 403 response is returned for HEAD requests when file does not exist and user does not have s3:ListBucket permissions. Added a more informative error message. Changed the s3utils function signatures to look more alike. Changed an instance of os.path to posixpath join in test_butler to be more consistent with what is expected from used URIs. Corrected Config.__initFromS3Yaml to use an URL instead of path and Config.__initFromYaml to use ospath.
DinoBektesevic
added a commit
to DinoBektesevic/daf_butler
that referenced
this pull request
Aug 6, 2019
Schemeless URIs handled more smoothly in ButlerURI. Removed s3CheckFileExistsGET and s3CheckFileExistsLIST for a singular s3CheckFileExists function, as botocore is up to date now on coda and on pip so GET/HEAD requests make no performance difference anymore. Live testing shows possibility that HTTP 403 response is returned for HEAD requests when file does not exist and user does not have s3:ListBucket permissions. Added a more informative error message. Changed the s3utils function signatures to look more alike. Changed an instance of os.path to posixpath join in test_butler to be more consistent with what is expected from used URIs. Corrected Config.__initFromS3Yaml to use an URL instead of path and Config.__initFromYaml to use ospath.
DinoBektesevic
added a commit
to DinoBektesevic/daf_butler
that referenced
this pull request
Aug 6, 2019
Schemeless URIs handled more smoothly in ButlerURI. Removed s3CheckFileExistsGET and s3CheckFileExistsLIST for a singular s3CheckFileExists function, as botocore is up to date now on coda and on pip so GET/HEAD requests make no performance difference anymore. Live testing shows possibility that HTTP 403 response is returned for HEAD requests when file does not exist and user does not have s3:ListBucket permissions. Added a more informative error message. Changed the s3utils function signatures to look more alike. Changed an instance of os.path to posixpath join in test_butler to be more consistent with what is expected from used URIs. Corrected Config.__initFromS3Yaml to use an URL instead of path and Config.__initFromYaml to use ospath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the prototype we called it
lsst.butlerbut following advice from @ktlim we are rebranding aslsst.daf.butler.