DM-38305: Fix race condition in DatasetRecordStorageManager refresh #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refresh of collection summaries could see newly added dataset types which are not picked by the manager refresh. As we only care about consistency between them, the fix is to ignore dataset types which are not known to the manager.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 85.63% 85.63% -0.01%
==========================================
Files 266 266
Lines 35180 35182 +2
Branches 7380 7380
==========================================
+ Hits 30127 30128 +1
Misses 3735 3735
- Partials 1318 1319 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TallJimbo
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh of collection summaries could see newly added dataset types which are not picked by the manager refresh. As we only care about consistency between them, the fix is to ignore dataset types which are not known to the manager.
Checklist
doc/changes