Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38235: Remove unused code related to schema digest calculation #806

Merged
merged 2 commits into from Mar 22, 2023

Conversation

andy-slac
Copy link
Contributor

Schema digests will no longer be written to butler_attributes table when registry database is initialized. The version of the DefaultButlerAttributeManager switched to 1.0.1, which is fully compatible with previous 1.0.0. daf_butler_migrate will add a migration script for 1.0.1.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (edd49df) 85.62% compared to head (6d15238) 85.57%.

❗ Current head 6d15238 differs from pull request most recent head a10d057. Consider uploading reports for the commit a10d057 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   85.62%   85.57%   -0.05%     
==========================================
  Files         266      266              
  Lines       35380    35227     -153     
  Branches     7447     7401      -46     
==========================================
- Hits        30293    30146     -147     
- Misses       3755     3757       +2     
+ Partials     1332     1324       -8     
Impacted Files Coverage Δ
...thon/lsst/daf/butler/registry/bridge/monolithic.py 87.25% <ø> (-0.25%) ⬇️
...on/lsst/daf/butler/registry/collections/nameKey.py 93.18% <ø> (-0.30%) ⬇️
...sst/daf/butler/registry/collections/synthIntKey.py 95.00% <ø> (-0.17%) ⬇️
.../butler/registry/datasets/byDimensions/_manager.py 91.87% <ø> (-0.09%) ⬇️
...thon/lsst/daf/butler/registry/dimensions/static.py 89.04% <ø> (-0.51%) ⬇️
...ython/lsst/daf/butler/registry/obscore/_manager.py 80.35% <ø> (-0.24%) ⬇️
python/lsst/daf/butler/registry/opaque.py 95.58% <ø> (-0.13%) ⬇️
python/lsst/daf/butler/tests/_dummyRegistry.py 87.64% <ø> (+1.61%) ⬆️
python/lsst/daf/butler/registry/attributes.py 100.00% <100.00%> (ø)
...lsst/daf/butler/registry/interfaces/_versioning.py 81.48% <100.00%> (-7.81%) ⬇️
... and 2 more

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a "removal" news fragment for this please?

Schema digests will no longer be written to butler_attributes table
when registry database is initialized. The version of the
DefaultButlerAttributeManager switched to 1.0.1, which is fully
compatible with previous 1.0.0. daf_butler_migrate will add a migration
script for 1.0.1.
@andy-slac andy-slac merged commit 734c93b into main Mar 22, 2023
11 checks passed
@andy-slac andy-slac deleted the tickets/DM-38235 branch March 22, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants