DM-10302 Change flux->instFlux #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
6659f0b
to
784d970
Compare
r-owen
approved these changes
Sep 14, 2018
| @@ -37,8 +37,7 @@ def assertCatalogEqual(self, inputCatalog, outputCatalog): | |||
| inputRecord = inputCatalog[0] | |||
| outputTable = outputCatalog.getTable() | |||
| outputRecord = outputCatalog[0] | |||
| self.assertEqual(inputTable.getPsfFluxDefinition(), outputTable.getPsfFluxDefinition()) | |||
There was a problem hiding this comment.
Why did you remove this instead of renaming it?
There was a problem hiding this comment.
There's nothing to rename it to: the *Definition() methods went away entirely, and the line immediately following tests that the data is there. Do you have a suggestion for a different test?
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
784d970
to
f1553cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.