Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38412: Improve schema version handling in Registry #810

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

andy-slac
Copy link
Contributor

This commit enables support of multiple schema versions by a single manager. Managers now have an access to the exact schema version as defined by the registry. Added unit test to check new functionality.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 94.80% and project coverage change: +2.02 🎉

Comparison is base (8cb2e88) 85.61% compared to head (25369b4) 87.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   85.61%   87.63%   +2.02%     
==========================================
  Files         266      267       +1     
  Lines       35314    34700     -614     
  Branches     7433     7290     -143     
==========================================
+ Hits        30234    30411     +177     
+ Misses       3749     3136     -613     
+ Partials     1331     1153     -178     
Impacted Files Coverage Δ
python/lsst/daf/butler/tests/_dummyRegistry.py 87.77% <60.00%> (+0.13%) ⬆️
python/lsst/daf/butler/registry/managers.py 86.39% <86.48%> (-0.73%) ⬇️
python/lsst/daf/butler/registry/versions.py 83.33% <92.50%> (+13.85%) ⬆️
...lsst/daf/butler/registry/interfaces/_versioning.py 91.07% <97.05%> (+9.58%) ⬆️
tests/test_versioning.py 98.23% <98.23%> (ø)
python/lsst/daf/butler/registry/attributes.py 100.00% <100.00%> (ø)
...thon/lsst/daf/butler/registry/bridge/monolithic.py 90.81% <100.00%> (+3.56%) ⬆️
...thon/lsst/daf/butler/registry/collections/_base.py 90.60% <100.00%> (+1.47%) ⬆️
...on/lsst/daf/butler/registry/collections/nameKey.py 97.61% <100.00%> (+4.43%) ⬆️
...sst/daf/butler/registry/collections/synthIntKey.py 98.27% <100.00%> (+3.27%) ⬆️
... and 12 more

... and 151 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This commit enables support of multiple schema versions by a single manager.
Managers now have an access to the exact schema version as defined by the
registry. Added unit test to check new functionality.
@andy-slac andy-slac merged commit f4ed9e1 into main Mar 29, 2023
13 checks passed
@andy-slac andy-slac deleted the tickets/DM-38412 branch March 29, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants