Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38514: Extend obscore query method to return fewer columns #811

Merged
merged 2 commits into from Mar 31, 2023

Conversation

andy-slac
Copy link
Contributor

ObsCoreTableManager.query method adds new parameter that accepts a list of column elements to return from a query instead of a full set of columns. This is used in re-implementation of dax_obscore CLI command.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f4ed9e1) 87.63% compared to head (847760a) 87.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   87.63%   87.64%           
=======================================
  Files         267      267           
  Lines       34700    34706    +6     
  Branches     7290     7294    +4     
=======================================
+ Hits        30411    30417    +6     
  Misses       3136     3136           
  Partials     1153     1153           
Impacted Files Coverage Δ
python/lsst/daf/butler/cli/cmd/commands.py 89.51% <100.00%> (-0.15%) ⬇️
...on/lsst/daf/butler/registry/interfaces/_obscore.py 100.00% <100.00%> (ø)
...ython/lsst/daf/butler/registry/obscore/_manager.py 82.65% <100.00%> (+0.73%) ⬆️
tests/test_obscore.py 98.70% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

`ObsCoreTableManager.query` method adds new parameter that accepts a
list of column elements to return from a query instead of a full set of
columns. This is used in re-implementation of dax_obscore CLI command.
@andy-slac andy-slac merged commit 77f0486 into main Mar 31, 2023
13 checks passed
@andy-slac andy-slac deleted the tickets/DM-38514 branch March 31, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants