Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38552: (hotfix) Stop relying on current working directory in repr test #815

Merged
merged 1 commit into from Apr 6, 2023

Conversation

timj
Copy link
Member

@timj timj commented Apr 6, 2023

The file URIs could urlencode some components of the path.

The test is not a good test. repr() tests rarely are.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The file URIs could urlencode some components of the path.
@timj timj requested a review from ktlim April 6, 2023 19:51
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 98.81% and project coverage change: +0.05 🎉

Comparison is base (400db07) 87.72% compared to head (9aecccd) 87.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   87.72%   87.77%   +0.05%     
==========================================
  Files         267      268       +1     
  Lines       34767    34935     +168     
  Branches     7316     7345      +29     
==========================================
+ Hits        30498    30665     +167     
  Misses       3116     3116              
- Partials     1153     1154       +1     
Impacted Files Coverage Δ
python/lsst/daf/butler/delegates/arrownumpydict.py 91.66% <91.66%> (ø)
python/lsst/daf/butler/formatters/parquet.py 93.67% <100.00%> (+0.70%) ⬆️
tests/test_datastore.py 99.53% <100.00%> (ø)
tests/test_parquet.py 99.13% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj merged commit 7d5ab35 into main Apr 6, 2023
13 checks passed
@timj timj deleted the tickets/DM-38552-hotfix branch April 6, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants