DM-38678: Make sure database connection is correctly closed #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some context query results caused database connection to stay open until all result rows are returned from iterator. This could cause nested database connections, which failed for SQLite in SQLAlchemy 2.0 due to database being locked. This patch retrieves all rows and closes database connection before starting iteration.
TallJimbo
approved these changes
Apr 13, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 87.74% 87.75%
=======================================
Files 268 268
Lines 34930 34932 +2
Branches 7346 7347 +1
=======================================
+ Hits 30651 30653 +2
Misses 3125 3125
Partials 1154 1154
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some contexts query results caused database connection to stay open until all result rows are returned from iterator. This could cause nested database connections, which failed for SQLite in SQLAlchemy 2.0 due to database being locked. This patch retrieves all rows and closes database connection before starting iteration.
Checklist
doc/changes