Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38694: Add StorageClassDelegate.copy() method #819

Merged
merged 2 commits into from May 4, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Apr 13, 2023

This allows for a future where in-memory datastore can decide whether to do copying when returning an object.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3e38a7b) 87.76% compared to head (1a976e6) 87.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   87.76%   87.77%           
=======================================
  Files         268      268           
  Lines       35246    35262   +16     
  Branches     7420     7421    +1     
=======================================
+ Hits        30935    30951   +16     
  Misses       3154     3154           
  Partials     1157     1157           
Impacted Files Coverage Δ
...ython/lsst/daf/butler/core/storageClassDelegate.py 49.59% <100.00%> (+2.58%) ⬆️
tests/test_storageClass.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj force-pushed the tickets/DM-38694 branch 3 times, most recently from 879fab8 to d563741 Compare April 19, 2023 22:47
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to test the alternate branch (failure) as well as the success branch.

timj added 2 commits May 4, 2023 10:14
This allows for a future where in-memory datastore can decide
whether to do copying when returning an object.
@timj timj merged commit 70814b1 into main May 4, 2023
13 checks passed
@timj timj deleted the tickets/DM-38694 branch May 4, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants