Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31924: deprecate aspects of the data ID packing system #820

Merged
merged 2 commits into from
Apr 27, 2023
Merged

DM-31924: deprecate aspects of the data ID packing system #820

merged 2 commits into from
Apr 27, 2023

Commits on Apr 26, 2023

  1. Deprecate non-configurable access to dimension packers. 

    This also moves test coverage for what will remain (here) of the
dimension packer system to test_dimensions.py, relying on a new
simpler concrete test packer.  All of the production concrete packers
will be defined in downstream packages going forward, and the
machinery for constructing them from a DimensionUniverse is being
deprecated, so all that remains to be tested is the DimensionPacker
ABC itself.
    @TallJimbo
    TallJimbo committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ec54f85 View commit details
    Browse the repository at this point in the history

  2. Make data ID handling in DimensionPacker.pack more convenient. 

    Most other interfaces allow pure kwargs as data IDs, and we can also
supply the "fixed" dimension values as a default.
    @TallJimbo
    TallJimbo committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d843b29 View commit details
    Browse the repository at this point in the history