Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38845: Fix row group computation crash if a list in a DataFrame is serialized to parquet. #828

Merged
merged 3 commits into from Apr 25, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Apr 24, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 92.30% and no project coverage change.

Comparison is base (9b39f79) 87.76% compared to head (83e8218) 87.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   87.76%   87.77%           
=======================================
  Files         268      268           
  Lines       35008    35032   +24     
  Branches     7368     7375    +7     
=======================================
+ Hits        30726    30748   +22     
- Misses       3124     3125    +1     
- Partials     1158     1159    +1     
Impacted Files Coverage Δ
python/lsst/daf/butler/formatters/parquet.py 93.67% <71.42%> (-0.38%) ⬇️
tests/test_parquet.py 99.16% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erykoff erykoff force-pushed the tickets/DM-38845 branch 2 times, most recently from 6a2512a to 2a5ae47 Compare April 24, 2023 22:35
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Fixes issues I found in ts_wep with dataframes and specifically dataframes with empty lists (which are now included in the tests here).

@erykoff erykoff merged commit 8698bcb into main Apr 25, 2023
13 checks passed
@erykoff erykoff deleted the tickets/DM-38845 branch April 25, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants