New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-37918: Change MetricMeasurementBundle import path #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is fine if you remove the underscore part of the name.
@@ -391,6 +391,6 @@ storageClasses: | |||
ScarletModelData: | |||
pytype: lsst.meas.extensions.scarlet.ScarletModelData | |||
MetricMeasurementBundle: | |||
pytype: lsst.analysis.tools.analysisMetrics.MetricMeasurementBundle | |||
pytype: lsst.analysis.tools.interfaces._metricMeasurementBundle.MetricMeasurementBundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytype: lsst.analysis.tools.interfaces._metricMeasurementBundle.MetricMeasurementBundle | |
pytype: lsst.analysis.tools.interfaces.MetricMeasurementBundle |
we don't include underscores in the name -- get_full_type_name
elides them from the hierarchy (that's deliberate because the underscore is meant to be an internal implementation details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must not be understanding something in how this works then:
In [1]: import lsst.analysis.tools.interfaces.MetricMeasurementBundle
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
Cell In[1], line 1
----> 1 import lsst.analysis.tools.interfaces.MetricMeasurementBundle
ModuleNotFoundError: No module named 'lsst.analysis.tools.interfaces.MetricMeasurementBundle'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was resolved on slack by Tim pointing out I was being dense.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 87.68% 87.77% +0.09%
==========================================
Files 268 268
Lines 35066 35032 -34
Branches 7383 7375 -8
==========================================
+ Hits 30746 30748 +2
+ Misses 3162 3125 -37
- Partials 1158 1159 +1
☔ View full report in Codecov by Sentry. |
fb652b7
to
0905b11
Compare
0905b11
to
457685e
Compare
Checklist
doc/changes