DM-38943: fix query-data-ids CLI handling of empty queries #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 87.73% 87.74%
=======================================
Files 268 268
Lines 35136 35154 +18
Branches 7397 7401 +4
=======================================
+ Hits 30828 30846 +18
Misses 3155 3155
Partials 1153 1153
☔ View full report in Codecov by Sentry. |
Previous code was inefficient most of the time (count() was used when any() would have been adequate), and failed when a pure SQL count was impossible since some filtering happened post-query in Python. The new version ignores that post-query filtering (via exact=False), but we catch that case later when we actually execute the real query.
TallJimbo
force-pushed
the
tickets/DM-38943
branch
from
3e44c14
to
1506d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes