Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38954: Fix duplicate join terms in spatial queries involving common skypix. #834

Merged
merged 1 commit into from May 3, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented May 2, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.01 🎉

Comparison is base (87c2bcf) 87.74% compared to head (5916c8d) 87.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   87.74%   87.76%   +0.01%     
==========================================
  Files         268      268              
  Lines       35154    35175      +21     
  Branches     7401     7407       +6     
==========================================
+ Hits        30846    30871      +25     
+ Misses       3155     3150       -5     
- Partials     1153     1154       +1     
Impacted Files Coverage Δ
...lsst/daf/butler/registry/interfaces/_dimensions.py 97.29% <ø> (ø)
...lsst/daf/butler/registry/queries/_query_backend.py 92.30% <ø> (ø)
.../daf/butler/registry/queries/_sql_query_backend.py 86.40% <83.33%> (-0.47%) ⬇️
...thon/lsst/daf/butler/registry/dimensions/static.py 89.74% <88.23%> (-0.54%) ⬇️
python/lsst/daf/butler/registry/tests/_registry.py 98.25% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment on lines 289 to 290
# incorrectly requiring that all visits and healpix10
# a common skypix pixel in commmon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revise this sentence, I think maybe "have" is missing somewhere, and having one "common" is probably enough?

@TallJimbo TallJimbo merged commit f655029 into main May 3, 2023
13 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-38954 branch May 3, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants