DM-39086: Out-of-date docs in butler prune-datasets #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 87.73% 87.73% -0.01%
==========================================
Files 268 268
Lines 35352 35352
Branches 7440 7440
==========================================
- Hits 31017 31016 -1
Misses 3169 3169
- Partials 1166 1167 +1
☔ View full report in Codecov by Sentry. |
ktlim
reviewed
May 8, 2023
ktlim
reviewed
May 8, 2023
TallJimbo
approved these changes
May 8, 2023
The argument is used when no other collections are provided, leading to surprising behavior for users who expected (or were afraid of) a global delete.
kfindeisen
force-pushed
the
tickets/DM-39086
branch
from
d7f9ac3
to
140b87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some out-of-date documentation in
butler prune-datasets --purgewhich led to surprising behavior when run without--unstoreor without thecollectionspositional argument.