Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39484: Fix password auth error creating Postgres registry #845

Merged
merged 1 commit into from Jun 2, 2023

Conversation

andy-slac
Copy link
Contributor

This commit allows passing URL to sqlalchemy methods without rendering it as a string. SQLite database still renders it internally and re-parses it again, just to keep code path intact.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@andy-slac andy-slac requested a review from timj June 1, 2023 23:04
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. makeEngine is missing the docstring patch for uri.

Also I suppose it's worthy of a DM-39484.bugfix.md noting this was a breakage from sqlalchemy2 transition.

This commit allows passing `URL` to sqlalchemy methods without rendering
it as a string. SQLite database still renders it internally and re-parses
it again, just to keep code path intact.
@andy-slac andy-slac merged commit da474ab into main Jun 2, 2023
11 checks passed
@andy-slac andy-slac deleted the tickets/DM-39484 branch June 2, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants