Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39410: Removed Ellipsis workaround from lsst.utils #847

Merged
merged 3 commits into from Jun 5, 2023

Conversation

andy-slac
Copy link
Contributor

With Python 3.10 we can use native types.EllipsisType for type annotations.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 80.55% and project coverage change: -0.01 ⚠️

Comparison is base (da474ab) 87.94% compared to head (9f5c732) 87.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   87.94%   87.93%   -0.01%     
==========================================
  Files         268      268              
  Lines       35258    35254       -4     
  Branches     7393     7393              
==========================================
- Hits        31006    31002       -4     
  Misses       3112     3112              
  Partials     1140     1140              
Impacted Files Coverage Δ
python/lsst/daf/butler/core/serverModels.py 78.57% <ø> (ø)
python/lsst/daf/butler/registries/remote.py 80.59% <ø> (-0.10%) ⬇️
python/lsst/daf/butler/registries/sql.py 84.96% <ø> (-0.03%) ⬇️
python/lsst/daf/butler/script/transferDatasets.py 44.44% <50.00%> (ø)
python/lsst/daf/butler/core/utils.py 94.28% <60.00%> (+0.16%) ⬆️
python/lsst/daf/butler/registry/wildcards.py 54.54% <75.00%> (ø)
python/lsst/daf/butler/registry/_registry.py 94.55% <100.00%> (ø)
...thon/lsst/daf/butler/registry/collections/_base.py 90.55% <100.00%> (-0.06%) ⬇️
.../butler/registry/datasets/byDimensions/_manager.py 93.62% <100.00%> (-0.04%) ⬇️
python/lsst/daf/butler/script/queryDataIds.py 86.66% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andy-slac andy-slac merged commit 953dbb1 into main Jun 5, 2023
11 of 13 checks passed
@andy-slac andy-slac deleted the tickets/DM-39410 branch June 5, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants