Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39663: Use Type rather than type[BaseModel] for protocol #851

Merged
merged 1 commit into from
Jun 14, 2023
Merged

DM-39663: Use Type rather than type[BaseModel] for protocol #851

merged 1 commit into from
Jun 14, 2023

Commits on Jun 14, 2023

  1. Use Type rather than type[BaseModel] for protocol 

    The "modern" version of the type confuses mypy, resulting
in messages such as:

python/lsst/pipe/base/graph/graph.py:1068: error: Invalid self argument "DatasetRef"
    to attribute function "to_json" with type "Callable[[SupportsSimple, bool], str]"  [misc]

when using `ref.to_json()`.
    @timj
    timj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7a6c4d7 View commit details
    Browse the repository at this point in the history