Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39781: Clean docs and add ruff configuration #856

Merged
merged 16 commits into from Jun 24, 2023
Merged

DM-39781: Clean docs and add ruff configuration #856

merged 16 commits into from Jun 24, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jun 23, 2023

This ruff configuration matches the flake8 and pydocstyle configurations already in place but fixes all the docstrings to enable ruff to run on the entire repository.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

pyproject.toml Outdated Show resolved Hide resolved
timj added 2 commits June 23, 2023 16:53
This runs clean with "ruff ." on tests and python directory.
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (50b5cb4) 88.01% compared to head (8714926) 88.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   88.01%   88.01%   -0.01%     
==========================================
  Files         269      269              
  Lines       35423    35420       -3     
  Branches     7424     7424              
==========================================
- Hits        31179    31176       -3     
  Misses       3103     3103              
  Partials     1141     1141              
Impacted Files Coverage Δ
python/lsst/daf/butler/_quantum_backed.py 88.60% <ø> (ø)
python/lsst/daf/butler/cli/butler.py 90.07% <ø> (ø)
python/lsst/daf/butler/cli/cliLog.py 76.72% <ø> (ø)
python/lsst/daf/butler/cli/cmd/commands.py 88.96% <ø> (ø)
python/lsst/daf/butler/cli/opt/optionGroups.py 88.88% <ø> (ø)
python/lsst/daf/butler/cli/opt/options.py 93.33% <ø> (ø)
python/lsst/daf/butler/cli/progress.py 100.00% <ø> (ø)
python/lsst/daf/butler/cli/utils.py 94.33% <ø> (ø)
python/lsst/daf/butler/core/datastore.py 94.76% <ø> (ø)
...ython/lsst/daf/butler/core/dimensions/_universe.py 88.53% <ø> (ø)
... and 100 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pyproject.toml Show resolved Hide resolved
tests/test_query_relations.py Show resolved Hide resolved
@timj timj merged commit e47b88e into main Jun 24, 2023
13 of 14 checks passed
@timj timj deleted the tickets/DM-39781 branch June 24, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants