Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-39582: Add caching for some butler primitives during deserialization #858
DM-39582: Add caching for some butler primitives during deserialization #858
Changes from all commits
1310356
97137a2
93e3286
498258d
a2805b3
b849bea
253a01d
ce5b439
fbf00cb
5432818
ef41fb5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 423 in python/lsst/daf/butler/core/datasets/ref.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/ref.py#L423
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rewrite this as
simple.datasetType is None and simple.dataId is None and simple.run is None
, I think it makes it easier to read?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not logically the same thing, We only want to run this when they are all
False
. But and is greedy, so False will always gobble up anything.Check warning on line 437 in python/lsst/daf/butler/core/datasets/ref.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/ref.py#L437
Check warning on line 475 in python/lsst/daf/butler/core/datasets/ref.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/ref.py#L475
Check warning on line 81 in python/lsst/daf/butler/core/datasets/type.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/type.py#L81
Check warning on line 99 in python/lsst/daf/butler/core/datasets/type.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/type.py#L99
Check warning on line 700 in python/lsst/daf/butler/core/datasets/type.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/type.py#L700
Check warning on line 734 in python/lsst/daf/butler/core/datasets/type.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datasets/type.py#L734
Check warning on line 211 in python/lsst/daf/butler/core/datastoreRecordData.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datastoreRecordData.py#L211
Check warning on line 220 in python/lsst/daf/butler/core/datastoreRecordData.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datastoreRecordData.py#L220
Check warning on line 231 in python/lsst/daf/butler/core/datastoreRecordData.py
Codecov / codecov/patch
python/lsst/daf/butler/core/datastoreRecordData.py#L231
Check warning on line 83 in python/lsst/daf/butler/core/dimensions/_coordinate.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_coordinate.py#L83
Check warning on line 96 in python/lsst/daf/butler/core/dimensions/_coordinate.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_coordinate.py#L96
Check warning on line 743 in python/lsst/daf/butler/core/dimensions/_coordinate.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_coordinate.py#L743
Check warning on line 758 in python/lsst/daf/butler/core/dimensions/_coordinate.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_coordinate.py#L758
Check warning on line 179 in python/lsst/daf/butler/core/dimensions/_records.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_records.py#L179
Check warning on line 191 in python/lsst/daf/butler/core/dimensions/_records.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_records.py#L191
Check warning on line 391 in python/lsst/daf/butler/core/dimensions/_records.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_records.py#L391
Check warning on line 416 in python/lsst/daf/butler/core/dimensions/_records.py
Codecov / codecov/patch
python/lsst/daf/butler/core/dimensions/_records.py#L416