Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40257: Enable skip_datastore for remove collections command #872

Merged
merged 1 commit into from Aug 2, 2023

Conversation

timj
Copy link
Member

@timj timj commented Aug 1, 2023

This command explicitly does not remove RUN collections so only affects registry.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj requested a review from andy-slac August 1, 2023 00:48
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (490508e) 87.80% compared to head (8fffe94) 87.81%.

Additional details and impacted files
@@            Coverage Diff            @@
##             main     #872     +/-   ##
=========================================
  Coverage   87.80%   87.81%             
=========================================
  Files         274      274             
  Lines       36049    36049             
  Branches     6102     7542   +1440     
=========================================
+ Hits        31654    31657      +3     
+ Misses       3225     3224      -1     
+ Partials     1170     1168      -2     
Files Changed Coverage Δ
python/lsst/daf/butler/script/removeCollections.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This command explicitly does not remove RUN collections
so only affects registry.
@timj timj merged commit 348c15d into main Aug 2, 2023
16 checks passed
@timj timj deleted the tickets/DM-40257 branch August 2, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants