DM-40297: Stop checking dataset existence when creating deferred dataset handle #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the datastore knows about a file that does not exist then we have serious problems but in most cases checking that the datastore knows about the file is enough.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 87.81% 87.82%
=======================================
Files 274 274
Lines 36049 36052 +3
Branches 7542 7543 +1
=======================================
+ Hits 31657 31662 +5
+ Misses 3224 3223 -1
+ Partials 1168 1167 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes