DM-38498: improve follow-up query support for QG generation use cases #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
+ Coverage 87.65% 87.67% +0.01%
==========================================
Files 272 272
Lines 36005 36107 +102
Branches 7529 7552 +23
==========================================
+ Hits 31560 31656 +96
Misses 3270 3270
- Partials 1175 1181 +6
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-38498
branch
2 times, most recently
from
c2ecaa9
to
9570f7c
Compare
TallJimbo
force-pushed
the
tickets/DM-38498
branch
6 times, most recently
from
4d5a0bb
to
1cf1130
Compare
andy-slac
approved these changes
Aug 22, 2023
Comment on lines
767
to
769
| raise ConflictingDefinitionError( | ||
| f"Existing dataset type or run do not match new dataset: {row._asdict()}" | ||
| ) |
There was a problem hiding this comment.
This looks like an unreachable code, all branches above raise exceptions.
Comment on lines
839
to
841
| raise ConflictingDefinitionError( | ||
| f"Existing dataset type and dataId does not match new dataset: {row._asdict()}" | ||
| ) |
| def iter_data_ids_and_dataset_refs( | ||
| self, dataset_type: DatasetType, dimensions: DimensionGraph | None = None | ||
| ) -> Iterator[tuple[DataCoordinate, DatasetRef]]: | ||
| """Iterate over pairs of data IDs and dataset refs. |
There was a problem hiding this comment.
Doesn't dataset ref include its data ID?
There was a problem hiding this comment.
It does, but these data IDs may have different dimensions from the dataset type. I'll point that out in the docs.
|
|
||
| Returns | ||
| ------- | ||
| pairs : `~collections.abc.Iterable` [ `tuple` [ `DataCoordinate`, |
There was a problem hiding this comment.
Iterator instead of Iterable?
| initial_join_max_columns=frozenset(self._relation.columns), | ||
| governor_constraints=self._governor_constraints, | ||
| spatial_joins=spatial_joins, | ||
| ) |
There was a problem hiding this comment.
I'd need another day to understand the details in the code above, so I just trust it is OK. 🙂
TallJimbo
force-pushed
the
tickets/DM-38498
branch
from
aa95802
to
2c33bb0
Compare
This is the butler functionality that will finally let us avoid the death-by-many-tiny-queries performance problem in QuantumGraph generation for (in particular) ISR.
This will allow reference catalog queries in QG generation to be vectorized as long as they use the common skypix system.
Just had to debug some of these, and found the integer primary keys embedded in the old messages hard to use. Unfortunately I couldn't get rid of all of them: this code has no access to the general mapping from dataset type ID to dataset type name. But I think that's the least likely field to be causing the conflict here, so it's not a huge loss.
Make use of the serialization caches when calling `to_simple` on dimension records.
TallJimbo
force-pushed
the
tickets/DM-38498
branch
from
2c33bb0
to
fd2474a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes