DM-40366: Use default pydantic model for testing #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we changed the pydantic models used in testing to be the compatibility models that understand v1 and v2. This is fine but means that any external users using pydantic models as butler datasets break if they are still using v1. Change the test model to use whatever is the native pydantic and then the YAML formatter has been modified to support both APIs. The JSON formatter already supported both.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 87.72% 87.71% -0.02%
==========================================
Files 274 274
Lines 36096 36107 +11
Branches 7549 7552 +3
==========================================
+ Hits 31665 31670 +5
- Misses 3259 3264 +5
- Partials 1172 1173 +1
☔ View full report in Codecov by Sentry. |
tgoldina
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we changed the pydantic models used in testing to be the compatibility models that understand v1 and v2. This is fine but means that any external users using pydantic models as butler datasets break if they are still using v1.
Change the test model to use whatever is the native pydantic and then the YAML formatter has been modified to support both APIs. The JSON formatter already supported both.
Checklist
doc/changes